Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Async Formatters #1347

Closed
retrohacker opened this issue May 13, 2017 · 1 comment
Closed

Remove Async Formatters #1347

retrohacker opened this issue May 13, 2017 · 1 comment
Labels

Comments

@retrohacker
Copy link
Member

Feature Request

Use Case

Currently the 5.x branch supports async formatters, however internally there is no way to support them and maintain the current restify API. After exploring possible solutions (i.e. #885), we have decided to drop support for async formatters prior to shipping 5x. The implications of this are that users will need to handle all asynchronous rendering outside of the restify stack, providing res.send et. al. values that are capable of being serialized synchronously.

Example API

Identical to restify 4.x formatters

Are you willing and able to implement this?

Yes 😄

@retrohacker
Copy link
Member Author

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant