Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: inlcude formatter documentation on website #1602

Merged
merged 1 commit into from Mar 17, 2018
Merged

Conversation

retrohacker
Copy link
Member

Note: Once this PR lands, we need to open a PR against the website updating the docs.yml file, updating the gitsha for this project, and trigger a rebuild of the website.

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes: #1594

We had a breaking change to the formatter API (we dropped support for async formatters) but the website was missing documentation so this wasn't apparent to the community.

Changes

  • Generate documentation for the formatter files
  • Add a type definition for the formatter function API

Broken windows

Fixing a few things I noticed.

  • Re-running docs updated the MDN links (sorry for the large commit)
  • server was misspelled as srv in a few places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants