Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published version on npm includes unnecessary large log files #1816

Closed
3 tasks done
jbt opened this issue Feb 20, 2020 · 2 comments · Fixed by #1818
Closed
3 tasks done

Published version on npm includes unnecessary large log files #1816

jbt opened this issue Feb 20, 2020 · 2 comments · Fixed by #1818

Comments

@jbt
Copy link

jbt commented Feb 20, 2020

  • Used appropriate template for the issue type
  • Searched both open and closed issues for duplicates of this issue
  • Title adequately and concisely reflects the feature or the bug

Bug Report

Restify Version

8.5.1

Node.js Version

N/A

Expected behaviour

Installed files from NPM shouldn't include any extraneous files

Actual behaviour

Currently the published version on npm includes three large log files totalling 1.7MB

isolate-0x102801e00-74163-v8.log (500526 bytes)
isolate-0x103000000-74139-v8.log (660871 bytes)
isolate-0x103000000-74561-v8.log (633352 bytes)

Repro case

npm install restify@8.5.1

Cause

There's a *.log in .gitignore that should probably also be in .npmignore to prevent those files from being published. Or alternatively a "files" entry in package.json to explicitly specify the files that should be included (since there are also a few much smaller unnecessary files currently included, like eslint/prettier config files)

Are you willing and able to fix this?

I'll gladly make a PR to add *.log into .npmignore if that would help - but I'm not sure whether I should be the one to make the call between that or going with a files list in the package.json

@retrohacker
Copy link
Member

Heh @hekike your isolates are leaking 😛

@retrohacker
Copy link
Member

Thank you for letting us know @jbt. I'll get a PR going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants