Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing fails if query params contains a "/", encoded or not #59

Closed
funston opened this issue Jan 28, 2012 · 2 comments
Closed

Routing fails if query params contains a "/", encoded or not #59

funston opened this issue Jan 28, 2012 · 2 comments

Comments

@funston
Copy link

funston commented Jan 28, 2012

If you create a route, and pass in something like foo="bar / foo" restify will fail to parse that and throw a 404. it appears to be parsing the route and including any "/" found in query params.

var restify = require('restify');

var server = restify.createServer();
server.get("/", function(req,res){
console.log("hello");
res.write("hello");
res.end();
});
server.listen(8090);

if you call it like this, you'll never see the request as restify will 404 it:

http://localhost:8090/?foo=Firefox%20901%20%2F%20Windows

@funston
Copy link
Author

funston commented Jan 28, 2012

removing. was using an older version. working in 1.x

@funston funston closed this as completed Jan 28, 2012
mcavage added a commit that referenced this issue Jan 28, 2012
mcavage added a commit that referenced this issue Jan 28, 2012
@mcavage
Copy link
Contributor

mcavage commented Jan 28, 2012

Well, this had nothing to do with query parsing, and just that restify 1.0 had a bug where if the route was exactly /, it would 404. Which is why it's still in beta ;) Anyway, it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants