New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in readme.txt that shows after installing package #886
Comments
There is a pull request for this, let me check on that. |
@behoyh I've checked that, it looks like it is accepted. But what about setting default serializer for RestClient? Is it possible to add? |
The default is JsonDeserializer - after you call client.Execute(request); You can't change this default. |
@behoyh what I mean was that in readme.txt is bug (already fixed by PR You mentioned). |
@behoyh there is one thing missing - deserializer in custom serialize class You guys mention in readme.txt. Also It would be great is we can set serializer and deserializer for client, so all request would use them. |
The readme is fixed and we will also change how serialisers are customised, it will be in the documentation. |
Inside readme.txt that is shown when we install ReshSharp package we see how to enable Newtonsoft.JSON serializer:
but
RestClient
doesn't haveJsonSerializer
property.This should be changed to:
Also this allows us to specify serializer for each request. Is there an option to specify default serializer for RestClient?
Ideally this should be a property of RestClient as shown in readme.txt, so instead fixing readme.txt just add that property to
RestClient
.The text was updated successfully, but these errors were encountered: