Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting rate limit lower than 10 stuck forever #6

Closed
AaronChen0 opened this issue Jun 8, 2021 · 5 comments
Closed

setting rate limit lower than 10 stuck forever #6

AaronChen0 opened this issue Jun 8, 2021 · 5 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@AaronChen0
Copy link

Failed examples:
armada 74.125.130.147 --top100 --rate-limit 2
armada 58.250.137.36 --top100 --rate-limit 9

Working examples:
armada 74.125.130.147 --top100 --rate-limit 10
armada 58.250.137.36 --top100 --rate-limit 11

~# armada --version
armada 1.0.2

@d0nutptr
Copy link
Contributor

d0nutptr commented Jun 8, 2021

Ahh yes so I'm aware of this behavior but didn't really expect anyone to want a rate-limit lower than 10 to be used.

Can you explain your use-case for wanting to run it that slowly?

@AaronChen0
Copy link
Author

Actually, I don't have to run it that slow. Sometimes, testing armada against specific sites for top100 ports, you have to set the rate limit lower and lower to avoid false negative. But I haven't encounter a site that would require to be that slow. Setting as low as 500 would be enough for most cases. It would be better to document this behavior, saying --rate-limit should be no smaller than 10.

@d0nutptr
Copy link
Contributor

d0nutptr commented Jun 8, 2021

Sounds good. What do you think about silently capping the minimum to 10? I can note something about this in the readme.

@d0nutptr d0nutptr added bug Something isn't working documentation Improvements or additions to documentation labels Jun 8, 2021
@AaronChen0
Copy link
Author

Agree.

@d0nutptr
Copy link
Contributor

d0nutptr commented Mar 2, 2024

This was resolved by the aforementioned PR

@d0nutptr d0nutptr closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants