Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: What's the reason for using murmur hash? #6

Open
gaurav-gogia opened this issue Jul 13, 2023 · 1 comment
Open

Question: What's the reason for using murmur hash? #6

gaurav-gogia opened this issue Jul 13, 2023 · 1 comment

Comments

@gaurav-gogia
Copy link

Hey,

I just wanted to ask the reason for using murmur hash here instead of some other cryptographically strong hash like SHA3 or BLAKE3 or something? Wouldn't using murmur hash affect accuracy of results? I understand that you are optimising for memory instead of CPU so I feel using a cryptographically secure hash will still stay aligned with your goals.

Please advise if my thoughts are correct here. Thanks

@muirdm
Copy link

muirdm commented Aug 19, 2023

Cryptographically secure hashes are slower. Since this is not a cryptographic application, I went with murmur, which was a good combination of speed and uniformity.

Originally the hash was configurable via the hash.Hash interface, but that was too slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants