New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConPty APIs #699
Add ConPty APIs #699
Conversation
There's no need to feature gate things based on Windows version because extern functions are only linked to when used. That said, if you do use these functions then your program won't run at all on older Windows versions unless you use |
Cool. I'd rather not use Do you need anything else to make this PR mergeable? |
1809 is now GA, so ConPTY should be available on updated Windows 10 systems. |
I've moved HPCON to |
When moving existing definitions to a different header, please put in Also when adding a new header, you also have to update the feature array in |
Thanks - will fixup tomorrow morning :) |
Have corrected all that now. Many thanks for your patience in helping refine all the bits I originally missed. Would a separate PR be useful to extend the notes in CONTRIBUTING to make those points clearer? |
Just wondering if there's anything else you'd like to see to have this merged? |
@retep998 just pinging to say we're hoping to merge alacritty/alacritty#1762 but would like to see these definitions merged into winapi first (we're using this patch I'm providing). Please let me know if there's anything left I can do to help this PR merge. |
Thanks! |
Closes #695.
I added the bare minimum to cover those three functions. These APIs will only work on the very newest Windows. Does anything need to be done to feature gate them?