Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have Object Equality #111

Closed
JoeyZwicker opened this issue Nov 26, 2012 · 3 comments
Closed

We should have Object Equality #111

JoeyZwicker opened this issue Nov 26, 2012 · 3 comments
Assignees
Milestone

Comments

@JoeyZwicker
Copy link

For groupBy, distinct...

@ghost ghost assigned jdoliner Nov 26, 2012
@coffeemug
Copy link
Contributor

Not sure if you guys had this discussion already (if so, please disregard this), but object equality isn't enough to implement this. We need to implement a comparison class for json data to make this work. This isn't particularly difficult (we discussed an acceptable comparator definition in one of our working groups), but I thought I'd mention it for posterity.

Also, this will automagically fix #103 when it's done.

@jdoliner
Copy link
Contributor

Well for groupBy and distinct you don't actually need a comparison operator although it will require doing a linear scan rather than a logarithmic one which isn't good. Like you said we have a perfectly reasonable definition for this so we should just add it.

@jdoliner
Copy link
Contributor

Status update:
A proposed solution for this is in code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants