Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for cache_size is wrong #1365

Closed
AtnNn opened this issue Aug 27, 2013 · 7 comments
Closed

The documentation for cache_size is wrong #1365

AtnNn opened this issue Aug 27, 2013 · 7 comments
Assignees
Milestone

Comments

@AtnNn
Copy link
Member

AtnNn commented Aug 27, 2013

cache_size(number): set the cache size (in MB) to be used by the table. Default is 1024MB;

However the code seems to assume it is in bytes:

        int cache_size = 1073741824;
        if (counted_t<val_t> v = optarg("cache_size")) {
            cache_size = v->as_int<int>();
        }
@ghost ghost assigned AtnNn Aug 27, 2013
@neumino
Copy link
Member

neumino commented Aug 27, 2013

The web interface asks for a number of MB. It does the conversion in admin/static/coffee/namespace/index.coffee line 444.

I don't know about the CLI though. Pinging @Tryneus

@AtnNn
Copy link
Member Author

AtnNn commented Aug 27, 2013

Sorry, this is in the documentation for table_create

@danielmewes
Copy link
Member

Yeah, pretty sure the documentation is wrong. It must be given in bytes not in MB. Stumbled across this before but forgot to open an issue.

@coffeemug
Copy link
Contributor

Also, this setting will likely go away when #97 is done.

@jdoliner
Copy link
Contributor

Why would this setting go away?

@coffeemug
Copy link
Contributor

Because as you pointed out to me once, it's unclear what it actually means.

@Tryneus
Copy link
Member

Tryneus commented Aug 27, 2013

@neumino, the CLI doesn't have any commands that set a table's cache size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants