Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve batched replace logic #1468

Closed
mlucy opened this issue Sep 20, 2013 · 1 comment
Closed

Improve batched replace logic #1468

mlucy opened this issue Sep 20, 2013 · 1 comment
Assignees
Milestone

Comments

@mlucy
Copy link
Member

mlucy commented Sep 20, 2013

I was doing some profiling on an insert workload, and our batched replace code could use some work.

On a batched insert where the actual call to access->get_namespace_if()->write(...) takes about 50ms, you can expect to spend another 5-10ms just constructing/destructing the vector of datum_func_pair_ts. (The rest of the work, including JSON parsing, comes out to around 6ms.)

The situation is worse for actual batched replaces. As far as I can tell from looking at the code, if we have a batched replace containing 10 point replaces, we serialize the replacement function 10 times.

The batched_replace code needs to be reworked so that instead of always having a vector of <key,function> pairs, it has either a vector of <key,datum> pairs or a vector of keys with a single function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant