Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin RethinkDB to a concrete v8 version and fetch it during build #1844

Closed
coffeemug opened this issue Jan 11, 2014 · 3 comments
Closed

Pin RethinkDB to a concrete v8 version and fetch it during build #1844

coffeemug opened this issue Jan 11, 2014 · 3 comments
Assignees
Milestone

Comments

@coffeemug
Copy link
Contributor

Talked to @AtnNn about it, we agreed to do what other software with this problem does -- pin to a v8 version and update it at our convenience.

@anatol
Copy link
Contributor

anatol commented Jan 16, 2014

This is fine with me (as a package maintainer). I assume you'll be bumping v8 version periodically.

FYI current stable version is 3.22 according to http://omahaproxy.appspot.com/

@AtnNn
Copy link
Member

AtnNn commented Feb 5, 2014

I updated #1510 with some #defines to be able to build against older versions of v8 and I've bumped the v8 version to 3.22.24.17.

As part of its build process, v8 downloads and builds icu.

I have also tested building rethinkdb with the dev version of v8 (3.24.30.1) and there are lots of errors, the API seems to have changed a lot.

@AtnNn
Copy link
Member

AtnNn commented Feb 8, 2014

For #1231 I am avoiding fetching anything during the build process. To close this issue, I will include v8 in the source distribution (http://download.rethinkdb.com/dist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants