Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin interface picks up wrong IP address #22

Closed
samstokes opened this issue Nov 11, 2012 · 5 comments
Closed

Admin interface picks up wrong IP address #22

samstokes opened this issue Nov 11, 2012 · 5 comments
Milestone

Comments

@samstokes
Copy link

After a fresh install on Ubuntu 11.10, I was surprised to see the admin interface (http://localhost:8080/#servers/[server-id]) claim that my server's IP address was 192.168.46.1 (while I was expecting something on the 192.168.1.0/24 subnet). It turns out 192.168.46.1 is the IP address of "vmnet1", a virtual network adapter that VMWare Workstation installed. I guess RethinkDB is using some heuristic to choose which adapter to report.

Not sure yet whether this has any practical consequences, but it was at least surprising.

@mglukhovsky
Copy link
Member

Sam, thanks for pointing this out.

We should improve the heuristic used to pick the IP address, or at least indicate which adapter we're picking from the server in question. It certainly doesn't have any practical consequences, but I'll see what we can do to improve this in the admin interface.

@skorokithakis
Copy link

It should probably do what is described in my feature request here: #28, both for the server and admin interface (perhaps separately configurable).

@coffeemug
Copy link
Contributor

Temporarily moving to backlog -- there are some more pressing issues to work out first.

@coffeemug
Copy link
Contributor

Now that #28 is done, we can actually address this. The easiest way for this to work is probably for the server to report which addresses it's actually listening on, and have the client report those. I'm not sure if this can make it into 1.5, I'll see what the good dev people have to say about it and report back.

@danielmewes danielmewes modified the milestones: outdated, backlog Oct 8, 2014
@danielmewes
Copy link
Member

Closing. #28 has been addressed so I don't think there's actually any remaining issue here. Unless I misunderstand the scope of the issue?

(also @Tryneus has rewritten much of the IP address handling I believe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants