Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we only serialize valid pseudotypes #2412

Open
danielmewes opened this issue May 19, 2014 · 0 comments
Open

Ensure we only serialize valid pseudotypes #2412

danielmewes opened this issue May 19, 2014 · 0 comments
Milestone

Comments

@danielmewes
Copy link
Member

In issue #2399 a table became inaccessible because a r.literal() pseudo-type made it to disk. When reading the value back, an exception was thrown and the deserialization of the datum_t failed.

We should add a verification to datum_t's serialization code to make sure that illegal pseudotypes are not written to disk.
What makes this slightly more complicated is that the question of whether a given r.literal is legal or not depends on the context of the serialization. It is never legal to write one to disk, while it is sometimes legal to serialize it for a network message.

@danielmewes danielmewes added this to the backlog milestone May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant