Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user specifiy tmp directroy for dump and import functions #2783

Closed
bigtree3131 opened this issue Jul 30, 2014 · 7 comments
Closed

Let user specifiy tmp directroy for dump and import functions #2783

bigtree3131 opened this issue Jul 30, 2014 · 7 comments
Assignees
Milestone

Comments

@bigtree3131
Copy link

For users who's cluster will not fit in /tmp, this is a must.

parser.add_option("-d", "--tmp-dir", dest="tmp_dir", default=None, type="string")

def run_rethinkdb_export(options):
# Create a temporary directory to store the intermediary results
temp_dir = tempfile.mkdtemp(dir=options["tmp_dir"])

@mlucy mlucy added this to the 1.14-polish milestone Jul 30, 2014
@mlucy
Copy link
Member

mlucy commented Jul 30, 2014

Thanks @bigtree3131 !

@Tryneus, does this seem reasonable?

@Tryneus
Copy link
Member

Tryneus commented Jul 30, 2014

Yeah, I can add this fairly easily.

@bigtree3131
Copy link
Author

Thanks!

@Tryneus
Copy link
Member

Tryneus commented Aug 9, 2014

Ok, finally got around to this! This has been approved in review 1921 and merged to next in commit 8aa7ee1. Cherry-picked into v1.14.x in commit 7cb0b50. Will be in release 1.14.

Note for anyone using an older version of the python driver: since we use tempfile.mkdtemp, you can specify this using environment variables (see https://docs.python.org/2/library/tempfile.html#tempfile.tempdir).

Thanks for bringing this to our attention, @bigtree3131!

@Tryneus Tryneus closed this as completed Aug 9, 2014
@AtnNn AtnNn modified the milestones: 1.14-polish, 1.14 Aug 9, 2014
@Tryneus
Copy link
Member

Tryneus commented Aug 13, 2014

Cherry-picked this into v1.13.x in commit e1b5042, because it may be useful to people backing up their databases before upgrading to v1.14.0. This will be in release 1.13.4.

@Tryneus Tryneus modified the milestones: 1.14, 1.13.x Aug 13, 2014
@larkost
Copy link
Collaborator

larkost commented Aug 18, 2014

@bigtree3131: This fix is in RethinkDB 1.13.4, which we released today.

@bigtree3131
Copy link
Author

Awesome! Thanks @Tryneus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants