Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how ready_* fields on rethinkdb.table_status are grouped #3269

Closed
timmaxw opened this issue Oct 31, 2014 · 3 comments
Closed

Change how ready_* fields on rethinkdb.table_status are grouped #3269

timmaxw opened this issue Oct 31, 2014 · 3 comments
Assignees
Milestone

Comments

@timmaxw
Copy link
Member

timmaxw commented Oct 31, 2014

Splitting this out from #3064:

We should also group the ready_* fields under a nested status field as follows:

{
    'status': {
      'ready_completely': True,
      'ready_for_outdated_reads': True,
      'ready_for_reads': True,
      'ready_for_writes': True,
  }
}

We should also rename ready_completely to all_replicas_ready.

@timmaxw timmaxw added this to the reql-admin-polish milestone Oct 31, 2014
@danielmewes danielmewes modified the milestones: reql-admin, reql-admin-polish Nov 1, 2014
@timmaxw
Copy link
Member Author

timmaxw commented Nov 7, 2014

I've implemented this and I'll put it up for review once CR 2285 is done.

@timmaxw timmaxw self-assigned this Nov 7, 2014
@timmaxw
Copy link
Member Author

timmaxw commented Nov 10, 2014

This is up for review in CR 2293.

@timmaxw
Copy link
Member Author

timmaxw commented Nov 12, 2014

Merged into reql_admin in 5ef9e3b.

@timmaxw timmaxw closed this as completed Nov 12, 2014
@danielmewes danielmewes modified the milestones: reql-admin, 1.16 Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants