Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cJSON by rapidjson #3844

Closed
danielmewes opened this issue Feb 26, 2015 · 4 comments
Closed

Replace cJSON by rapidjson #3844

danielmewes opened this issue Feb 26, 2015 · 4 comments
Assignees
Milestone

Comments

@danielmewes
Copy link
Member

https://github.com/miloyip/rapidjson is usually faster than cJSON.

I've already started a branch with a partial port in daniel_rapidjson.

@danielmewes
Copy link
Member Author

Implemented in branch daniel_rapidjson, in CR 2801 by @Tryneus.

@mlucy
Copy link
Member

mlucy commented Apr 11, 2015

@danielmewes -- it might be worth auditing the rapidjson code to see whether they parse and print doubles in a way that doesn't discard information. I don't think we have a test for that right now.

@danielmewes
Copy link
Member Author

@mlucy Good point. It does round differently from cJSON (this shows up in the geospatial tests). I haven't investigated that yet, but it might indeed discard some information on the way. I'll add a separate test and investigate.

@danielmewes
Copy link
Member Author

Merged into next 9504c0d .

The output of JSON-related commands such as coerce_to('string') and to_json_string() as well as some error messages that include user data will change slightly in format due to this.

Old secondary indexes keep using cJSON for these operations for the time being to maintain compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants