Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user specify some replicas as voters and some as non-voters #3891

Closed
timmaxw opened this issue Mar 4, 2015 · 12 comments
Closed

Let user specify some replicas as voters and some as non-voters #3891

timmaxw opened this issue Mar 4, 2015 · 12 comments
Assignees
Milestone

Comments

@timmaxw
Copy link
Member

timmaxw commented Mar 4, 2015

In raft right now, consensus is defined as a majority of all replicas. We should let the user specify replicas that aren't used for consensus. This could take the form of another field in table_config called non_voting_replicas, or something.

@timmaxw timmaxw added this to the raft-polish milestone Mar 4, 2015
@danielmewes
Copy link
Member

What's an example use case of this?

@timmaxw
Copy link
Member Author

timmaxw commented Mar 4, 2015

Suppose the user has three replicas in a datacenter in Boston and one replica in each of three "satellite" datacenters in San Francisco, Hong Kong, and Paris. The primaries are all in the Boston datacenter, and the user wants writes to be acknowledged without doing a complete network round-trip to one of the remote datacenters. So they set the satellite replicas as non-voting.

@danielmewes
Copy link
Member

Got it, thanks

@VeXocide
Copy link
Member

VeXocide commented May 6, 2015

Moving to the raft milestone due to #3894.

@VeXocide VeXocide modified the milestones: raft, raft-polish May 6, 2015
@danielmewes
Copy link
Member

I think it's actually not critical that we support this for #3894 . Just single and majority acks should be enough for the first release.

We might get this as a side effect of implementing hard override, but in itself I think it's not release critical.

@danielmewes danielmewes modified the milestones: raft-polish, raft May 6, 2015
@VeXocide
Copy link
Member

VeXocide commented May 6, 2015

👍

@deontologician
Copy link
Contributor

This is just a reminder to do the webui portion whenever this is completed

@timmaxw timmaxw self-assigned this May 28, 2015
@timmaxw
Copy link
Member Author

timmaxw commented May 28, 2015

In CR 2925.

@deontologician
Copy link
Contributor

@timmaxw so do we need new webui functionality for this in your opinion?

@timmaxw
Copy link
Member Author

timmaxw commented May 28, 2015

The web UI should visually indicate which replicas are nonvoting, but other than that I don't think we need anything.

@danielmewes
Copy link
Member

The web UI should visually indicate which replicas are nonvoting, but other than that I don't think we need anything.

👍

@timmaxw
Copy link
Member Author

timmaxw commented Jun 2, 2015

Fixed in f706b90.

@timmaxw timmaxw closed this as completed Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants