Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable 'o' in Python encoder #4955

Closed
danielmewes opened this issue Oct 15, 2015 · 3 comments
Closed

Undefined variable 'o' in Python encoder #4955

danielmewes opened this issue Oct 15, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@danielmewes
Copy link
Member

I'm not sure if this line is ever hit, but I'm pretty sure that the o in https://github.com/rethinkdb/rethinkdb/blob/next/drivers/python/rethinkdb/ast.py#L701 should be obj.

@danielmewes danielmewes added this to the 2.2 milestone Oct 15, 2015
@asakatida
Copy link
Contributor

It seems to never be hit in my usage. I'm updating my latest PR still.

@danielmewes
Copy link
Member Author

Thanks @grandquista! I also didn't hit this in practice. Just noticed it when looking at the code.

(@Tryneus is currently out of office, but he'll be back next week to look at the PR. So we should be able to get it all in on time for 2.2)

@asakatida
Copy link
Contributor

r.expr filters out any object of type that would trigger that line. I was looking at removing recursion from r.expr and that change would definitely trigger the line in some use cases. The line throws in either case. Fixing it just means the right error is thrown.

@Tryneus Tryneus self-assigned this Oct 20, 2015
@Tryneus Tryneus closed this as completed in e8c441b Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants