Get libc++ working with OS X.

[srh]

Right now we can't use anything in the C++11 library, which means we can't really use rvalue references because std::move and std::forward are unavailable.

This is because on OS X, specifying -stdlib=libc++ results in linking problems with libraries compiled with libstdc++. We need to hack some homebrew dependencies for protobuf and whatever else we depend on to compile with libc++.

This is a very high priority because fixing a lot of basic performance problems in the query language code and elsewhere would be much easier with rvalue references, and std::move and std::forward.

[srh]

@jmgao made some formulas to build node, protobuf, and v8, linking against libc++, at https://github.com/jmgao/homebrew-rethinkdb

Edit: its v8 is out of date. Use https://github.com/srh/homebrew-rethinkdb instead.

One way to get RethinkDB working on OS X is therefore to replace your node, protobuf, and v8 with these respective libraries. I'm going to make it do this and then link libc++11.

[AtnNn]

Related issues in homebrew:

Homebrew/legacy-homebrew#14939
Homebrew/legacy-homebrew#16078

[AtnNn]

@srh your code has been sitting in limbo for too long.

@coffeemug I assume we can't drop homebrew support.

I'll play with it and implement the easiest fix I can think of.

[coffeemug]

We can't drop homebrew.

[srh]

Making our own recipes that install to differently-named locations seems like the easiest and best fix. Then putting those in a ... tap or just having a raw URL in the instructions would do the trick. (Note that I don't actually know what a tap is.)

libc++'s subtly different behavior in its implementations has been helpful by exposing bugs (two so far), and I'd really rather not strip it out of the reference-counting branch -- there's no technical difficulties in the code, but it would take less time to just make working homebrew recipes.

[coffeemug]

I don't like providing URLs in the instructions. We should just have a tap and install rethink (and all relevant dependencies) via that.

[AtnNn]

With that solution, the new instructions would simply be:

brew tap rethinkdb/rethinkdb
brew update
brew install rethinkdb

It'll be impossible for users to discover without visiting our website.

[coffeemug]

I think that's fine. (That's what we do on Ubuntu already)

[coffeemug]

Closing, since this is done in the codebase and the remaining work is captured by #740.

[AtnNn]

The sam_libcxx branch hasn't been merged into next yet, and it doesn't build on travis with clang.

[coffeemug]

Fair enough -- sorry. Reopening.

@srh -- could you fix the bugs caused by Travis's clang version? (darn you, Strunk and White apostrophe)

[srh]

In file included from build/release_clang/proto/rdb_protocol/ql2.pb.cc:4:

./build/release_clang/proto/rdb_protocol/ql2.pb.h:7:10: fatal error: 'string'

file not found

#include <string>

I don't know how to fix this.

[AtnNn]

I'll try to reproduce it, I've got a clone of the VM that travis uses.

[srh]

Well, it probably means my changes to the Makefile somehow accidentally applied outside of OS X.

[srh]

This problem is probably fixed in a45effd (under the theory that if the makefile isn't changed, clang shouldn't be confused).

[srh]

The problem is indeed fixed.

[srh]

sam_libcxx is now merged into next.

We still have #740 to do.

In the mean time, you can install the dependencies on your machine with

brew uninstall node protobuf v8
brew install https://raw.github.com/srh/homebrew-rethinkdb/master/node.rb
brew install https://raw.github.com/srh/homebrew-rethinkdb/master/protobuf.rb
brew install https://raw.github.com/srh/homebrew-rethinkdb/master/v8.rb