Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadriver ignores timeout? #5603

Closed
iorlas1 opened this issue Apr 5, 2016 · 2 comments
Closed

javadriver ignores timeout? #5603

iorlas1 opened this issue Apr 5, 2016 · 2 comments
Assignees
Milestone

Comments

@iorlas1
Copy link
Contributor

iorlas1 commented Apr 5, 2016

Noticed that in the javadriver the method DefaultCursor.getNext(Optional) ignores the timeout argument. I tried to make a change where the argument was passed to waitOnCursorItems() and to the awaitingContinue.get() method call. Worked fine for me.

I checked out the code but failed to run the tests - guess there is some setup that I need - so I haven't contributed my solution. I can build the code just fine though.

Any hints on what needs to be done to run the tests, or if someone else wants to fix the problem for me that is just fine as well.

Regards
Magnus

@danielmewes danielmewes added this to the 2.3-polish milestone Apr 5, 2016
@danielmewes
Copy link
Member

Thanks for the bug report @iorlas1 .

A pull request would be most welcome. We can run the tests on our end. (You might want to take a quick look at our CLA as well: http://rethinkdb.com/community/cla/ .)
In general the Java drive tests require a running RethinkDB server on your local machine. Then you can run them through gradle test in the drivers/java directory.

Also pinging @deontologician .

@danielmewes danielmewes modified the milestones: 2.3-polish, 2.3.x Apr 7, 2016
@danielmewes danielmewes modified the milestones: 2.3.x, 2.3.1 Apr 20, 2016
@danielmewes
Copy link
Member

Closed by #5618 . Will ship together with RethinkDB 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants