Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build-deb complains about node missing on next #6595

Closed
Tracked by #7067
srh opened this issue Jan 14, 2018 · 2 comments
Closed
Tracked by #7067

make build-deb complains about node missing on next #6595

srh opened this issue Jan 14, 2018 · 2 comments
Milestone

Comments

@srh
Copy link
Contributor

srh commented Jan 14, 2018

If you run make build-deb DEB_RELEASE=... you'll get a complaint that node is missing.

This is almost certainly related to my recent changes making web_assets.cc precompiled, so that Node isn't an immediate build dependency.

Only affects the next branch (not 2.4.x).

@srh srh added this to the 2.5 milestone Jan 14, 2018
@gabor-boros
Copy link
Member

@srh since 2.5 will be created from 2.4 (if I understand correctly) upon a breaking change, this issue is not valid anymore as the next branch became the snapshot of that work done there and "abandoned", right?

@srh
Copy link
Contributor Author

srh commented May 6, 2022

Right. We'll have to avoid this issue if/when cherry-picking from next. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants