Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server resource packet hash doesn't get received and sent by the client? #791

Closed
DemonDxv opened this issue May 19, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@DemonDxv
Copy link

Describe the bug
When the server sends out a WrapperPlayServerResourcePackSend on 1.8.9 the client doesn't send the hash that the server sent with it. The length of the string is always 0.

Software brand
Spigot 1.8.8-R0.1-SNAPSHOT (/about)

Plugins
ViaVersion, Spark, WorldGuard, Citizens, Strikepractice, PacketEvents, Essentials

How To Reproduce
Steps to reproduce the behavior:

  1. Send a resource packet out like this every so often or on a command.

PacketEvents.getAPI().getPlayerManager().sendPacket(player, new
WrapperPlayServerResourcePackSend(
"level://" + "test" + "/resources.zip",
"test", false,
null));

  1. Listen for the resource packet for the client, grab and debug the hash string from the packet it returns a 0 length string (PacketType.Play.Client.RESOURCE_PACK_STATUS)

Expected behavior
The client should give the hash that's provided when the server sends out the packet.

Screenshots
https://i.imgur.com/JAvTB6F.png
https://i.imgur.com/FzsHVaF.png

@DemonDxv DemonDxv added the bug Something isn't working label May 19, 2024
@retrooper
Copy link
Owner

On versions older than 1.10 (which happens to be your case), packetevents does recognize and write/read the hash within the packets. It could be that ViaVersion is modifying the packet and emptying the hash, causing you to experience this.

FYI: Versions 1.10+ have removed this hash.

Take away: Try without ViaVersion and see if it persists, inform us and maybe consider consulting with them.

@DemonDxv
Copy link
Author

DemonDxv commented May 21, 2024

On versions older than 1.10 (which happens to be your case), packetevents does recognize and write/read the hash within the packets. It could be that ViaVersion is modifying the packet and emptying the hash, causing you to experience this.

FYI: Versions 1.10+ have removed this hash.

Take away: Try without ViaVersion and see if it persists, inform us and maybe consider consulting with them.

  • I was wrong, I think its something to do with PacketEvents and bungeecord/velocity. As I tested without any plugins, and it still has the issue, but as soon as I go on a non bungee coord/velocity server (connecting straight to the server) running packet events its fine.

Edit:

So when using Velocity to connect to a server, that uses PacketEvents (on the spigot) it has this hash issue. If its not Velocity it doesn't have the issue (I made report to them: PaperMC/Velocity#1327)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants