Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV4 Play: Shows item image for both items and folders when listing #1774

Closed
3 of 7 tasks
matsarv opened this issue Mar 23, 2024 · 3 comments
Closed
3 of 7 tasks

TV4 Play: Shows item image for both items and folders when listing #1774

matsarv opened this issue Mar 23, 2024 · 3 comments
Assignees
Labels
bug Something isn't working tobereleased Item was closed but is not yet contained within a release
Milestone

Comments

@matsarv
Copy link
Contributor

matsarv commented Mar 23, 2024

Bug report

Describe the bug

Shows item image for both items and folders when listing

Expected Behavior

Show folder image when item is a folder and item image för item streams

Actual Behavior

All items is showing item image

Possible Fix

See below

To Reproduce

Steps to reproduce the behavior:

  1. Select TV4 Play
  2. Select Latest

Screenshots

Now:
1

Fix;
chn_tv4se.py
def create_api_series(self, result_set: dict) -> Optional[MediaItem]:
Line 409

from:
        item = FolderItem(title, url, content_type=contenttype.EPISODES, media_type=mediatype.TVSHOW)
to:
        item = FolderItem(title, url, content_type=contenttype.EPISODES, media_type=mediatype.FOLDER)

After:
2

Your Environment

Used Operating system:

  • Android
  • iOS
  • Linux
  • OSX
  • Raspberry-Pi
  • Windows
  • Windows UWP

Used versions:

  • Kodi version: 20.5
  • Retrospect version: 5.7.8
@matsarv matsarv added the bug Something isn't working label Mar 23, 2024
@basrieter basrieter self-assigned this Mar 24, 2024
Copy link

Branch bug-1774 was created for issue: "TV4 Play: Shows item image for both items and folders when listing"

@basrieter
Copy link
Collaborator

@matsarv
Copy link
Contributor Author

matsarv commented Mar 24, 2024

Now it works OK.
Nothing is broken so no need to rush out a new version.

@basrieter basrieter added the tobereleased Item was closed but is not yet contained within a release label Mar 24, 2024
@basrieter basrieter added this to the v5.7.9 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tobereleased Item was closed but is not yet contained within a release
Projects
None yet
Development

No branches or pull requests

2 participants