Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The delete button on inbox items stays disabled after cancelling the deletion operation #1427

Closed
pixeldesu opened this issue Oct 29, 2023 · 2 comments · Fixed by #1457
Closed

The delete button on inbox items stays disabled after cancelling the deletion operation #1427

pixeldesu opened this issue Oct 29, 2023 · 2 comments · Fixed by #1457
Assignees
@chahmedejaz
Labels
bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project

Comments

@pixeldesu
Copy link
Member

Steps to reproduce the problem

  1. Go to your inbox
  2. On an inbox entry, press "Delete"
  3. Press "Cancel"

Expected behaviour

The "Delete" button is clickable again.

Actual behaviour

The "Delete" button stays disabled.

Detailed description

No response

Specifications

Retrospring 2023.1028.1
@pixeldesu pixeldesu added bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project labels Oct 29, 2023
@milinddethe15
Copy link

Hi, I want to work on this. Assign me.

@milinddethe15 milinddethe15 removed their assignment Nov 2, 2023
@chahmedejaz
Copy link
Contributor

Hey @pixeldesu - I'd love to work on this issue. Can you please assign it to me? Thanks.

chahmedejaz added a commit to chahmedejaz/retrospring that referenced this issue Nov 6, 2023
@chahmedejaz
Retrospring#1427, fix disabled button issue
97d08e0
chahmedejaz added a commit to chahmedejaz/retrospring that referenced this issue Nov 6, 2023
@chahmedejaz
Retrospring#1427, disable button while deletion
2059827 
and re-enable if error
@chahmedejaz chahmedejaz mentioned this issue Nov 6, 2023
Merged
chahmedejaz added a commit to chahmedejaz/retrospring that referenced this issue Nov 6, 2023
@chahmedejaz
Retrospring#1427, remove unused returnValue
3f272fe
chahmedejaz added a commit to chahmedejaz/retrospring that referenced this issue Nov 6, 2023
@chahmedejaz
Retrospring#1427, fix disabled button issue
e881d6a
pixeldesu pushed a commit that referenced this issue Nov 9, 2023
@chahmedejaz @pixeldesu
#1427, fix disabled button issue
2392153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chahmedejaz chahmedejaz

Labels
bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix disabled button issue for the Inbox Question chahmedejaz/retrospring
3 participants
@pixeldesu @chahmedejaz @milinddethe15