Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thrust SFX in Asteroids can't be muted #104

Closed
d-klx opened this issue Jun 24, 2022 · 5 comments
Closed

Thrust SFX in Asteroids can't be muted #104

d-klx opened this issue Jun 24, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@d-klx
Copy link

d-klx commented Jun 24, 2022

First of all: Thanks so much for the effort you put into the games!
I love the app and enjoy it very much!

I think this is just a small bug, but somehow annoying, when listening to a podcast or music at the same time.

Describe the bug
There is some sound effect playing at the end of each use of the thrust although sound effects are muted.

To Reproduce
Steps to reproduce the behavior:

  1. Mute sound effects
  2. Play Asteroids and use the thrust

Expected behavior
No sound

@d-klx d-klx added the bug Something isn't working label Jun 24, 2022
@ig9000
Copy link

ig9000 commented Jun 24, 2022

I noticed this too. It seems that the "fade out" part of the thruster envelope is always played as a ramp from 100%, ignoring the volume setting (or muting) for the sound fx.

@d-klx: Do you happen to also see the same behavior of sounds not initially playing as described in #105? If not, it may just be related to my specific phone.

@pserwylo
Copy link
Member

Good pickup, I'll get that fixed up, it must be annoying!

@d-klx
Copy link
Author

d-klx commented Jun 25, 2022

@d-klx: Do you happen to also see the same behavior of sounds not initially playing as described in #105? If not, it may just be related to my specific phone.

@ig9000: Yes I have the same experience on my Pixel phone.

@pserwylo
Copy link
Member

Okay, v0.31.2 tagged and ready to be built/released by F-Droid within approx a week.

I must admit, the reason I didn't catch this is because I'm one of those lazy Asteroids players who camps in the centre of the screen and never-ever-ever moves anywhere for fear of getting disoriented and crashing into something :)

@d-klx
Copy link
Author

d-klx commented Jun 27, 2022

Okay, v0.31.2 tagged and ready to be built/released by F-Droid within approx a week.

I must admit, the reason I didn't catch this is because I'm one of those lazy Asteroids players who camps in the centre of the screen and never-ever-ever moves anywhere for fear of getting disoriented and crashing into something :)

Thanks so much.
That's definitely a very good excuse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants