Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to know if expired token is valid or not #7

Closed
brycx opened this issue Aug 22, 2020 · 1 comment · Fixed by #8
Closed

Impossible to know if expired token is valid or not #7

brycx opened this issue Aug 22, 2020 · 1 comment · Fixed by #8

Comments

@brycx
Copy link
Collaborator

brycx commented Aug 22, 2020

Because the token expiration check is performed before authentication and decryption, it's impossible to know if an expired token is valid or invalid.

An attacker may modify the timestamp, in the header, to make the token expire but the user would never know that it had been modified.

@tuupola
Copy link

tuupola commented Aug 24, 2020

Good catch. I seem to have same problem with pybranca. I think I should also mention this in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants