Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Scala: do not parse parenthesized expressions as unary tuples #526

Merged
merged 1 commit into from Jun 1, 2022

Conversation

mmcqd
Copy link
Member

@mmcqd mmcqd commented Jun 1, 2022

See semgrep/semgrep#5387

Security

  • Change has no security implications (otherwise, ping the security team)

@mmcqd mmcqd requested a review from a team June 1, 2022 20:35
@mmcqd mmcqd merged commit 5c27383 into develop Jun 1, 2022
@mmcqd mmcqd deleted the matthew/scala-one-tuples branch June 1, 2022 22:46
let (_,xs,_) as tuple = makeParens (commaSeparated expr) in_ in
begin
match xs with
| [x] -> x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need a ParenExpr at some point here :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants