Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Support for "implements" keyword is incomplete #1850

Closed
msorens opened this issue Oct 16, 2020 · 2 comments · Fixed by #1863
Closed

[typescript] Support for "implements" keyword is incomplete #1850

msorens opened this issue Oct 16, 2020 · 2 comments · Fixed by #1863
Assignees
@aryx @mjambon
Labels
bug Something isn't working lang:typescript

Comments

@msorens
Copy link

msorens commented Oct 16, 2020 •
edited

Describe the bug
This sample (https://semgrep.dev/s/Jq0Z/) illustrates that #1753 (Support matching on "implements") is incomplete. The red X cases are incorrect.

Additional Info

To Reproduce
https://semgrep.dev/s/Jq0Z/

Expected behavior
Multiple implemented interfaces must be supported.

Screenshots
image

Environment
Semgrep 0.27.0

(Priority for me: somewhat important)
@brendongo brendongo added bug Something isn't working lang:typescript labels Oct 20, 2020
@DrewDennison
Copy link
Member

@aryx this seems to be a matching / type bug. Tagging you for an investigation

@aryx
Copy link
Collaborator

aryx commented Oct 21, 2020

This works on develop: https://semgrep.dev/s/Jq0Z/?version=develop
Should be in 0.28 that we release today.

@aryx aryx closed this as completed Oct 21, 2020
aryx added a commit that referenced this issue Oct 21, 2020
@aryx
Test file showing you can match implements in any order in Typescript…
88b9a08 
… too

Closes #1850

test plan:
test file included
@aryx aryx mentioned this issue Oct 21, 2020
Merged
aryx added a commit that referenced this issue Oct 21, 2020
@aryx
Test file showing you can match implements in any order in Typescript…
42d9f9e 
… too (#1863)

Closes #1850

test plan:
test file included
aryx added a commit that referenced this issue Oct 21, 2020
@aryx
Allow method as toplevel semgrep pattern (#1865)
8fdb105 
* Test file showing you can match implements in any order in Typescript too

Closes #1850

test plan:
test file included

* Allow method as toplevel semgrep pattern

Fixes #1852

Test plan:
test file included
make test
msorens added a commit to chef/automate that referenced this issue Oct 22, 2020
@msorens
new rule: onDestroy-not-implemented-in-class
70014b9 
With this issue just resolved --
semgrep/semgrep#1850 --
I can now add this new rule.

Signed-off-by: michael sorens <msorens@chef.io>
msorens added a commit to chef/automate that referenced this issue Oct 23, 2020
@msorens
new rule: onDestroy-not-implemented-in-class
a591293 
With this issue just resolved --
semgrep/semgrep#1850 --
I can now add this new rule.

Signed-off-by: michael sorens <msorens@chef.io>
msorens added a commit to chef/automate that referenced this issue Oct 29, 2020
@msorens
new rule: onDestroy-not-implemented-in-class
c6a4cb5 
With this issue just resolved --
semgrep/semgrep#1850 --
I can now add this new rule.

Signed-off-by: michael sorens <msorens@chef.io>
msorens added a commit to chef/automate that referenced this issue Oct 31, 2020
@msorens
new rule: onDestroy-not-implemented-in-class
02ee135 
With this issue just resolved --
semgrep/semgrep#1850 --
I can now add this new rule.

Signed-off-by: michael sorens <msorens@chef.io>
msorens added a commit to chef/automate that referenced this issue Oct 31, 2020
@msorens
new rule: onDestroy-not-implemented-in-class
2a5fdc5 
With this issue just resolved --
semgrep/semgrep#1850 --
I can now add this new rule.

Signed-off-by: michael sorens <msorens@chef.io>
@johnzeringue johnzeringue mentioned this issue Feb 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

@mjambon mjambon

Labels
bug Something isn't working lang:typescript
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test file showing you can match implements in any order in Typescript too semgrep/semgrep
5 participants
@aryx @mjambon @DrewDennison @brendongo @msorens