Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Typed metavariables do not work for number and boolean #5350

Closed
aryx opened this issue May 30, 2022 · 1 comment · Fixed by #5352
Closed

[JS] Typed metavariables do not work for number and boolean #5350

aryx opened this issue May 30, 2022 · 1 comment · Fixed by #5352
Assignees
@aryx
Labels
lang:javascript pattern:types

Comments

@aryx
Copy link
Collaborator

aryx commented May 30, 2022

see https://semgrep.dev/s/W71j
@aryx aryx self-assigned this May 30, 2022
@r2c-demo
Copy link
Collaborator

This issue is synced in Linear at https://linear.app/r2c/issue/PA-1401/[js]-typed-metavariables-do-not-work-for-number-and-boolean. Note: this link is for r2c use only and is not accessible publicly.

aryx added a commit that referenced this issue May 30, 2022
@aryx
Introduce Type_generic.ml
c93a25b 
This refactors m_compatible_type to go in 2 steps:
one step to extract the type, and another for the match

This will help #5350

test plan:
make test
@aryx aryx mentioned this issue May 30, 2022
Merged
3 tasks
aryx added a commit that referenced this issue May 30, 2022
@aryx
Introduce Type_generic.ml (#5351)
16474b9 
This refactors m_compatible_type to go in 2 steps:
one step to extract the type, and another for the match

This will help #5350

test plan:
make test
aryx added a commit that referenced this issue May 30, 2022
@aryx
[TS] support boolean and number typed metavariables
bd30dc6 
This closes #5350

test plan:
test files included
make test
@aryx aryx mentioned this issue May 30, 2022
Merged
3 tasks
aryx added a commit that referenced this issue May 31, 2022
@aryx
[TS] support boolean and number typed metavariables (#5352)
351b70e 
This closes #5350

test plan:
test files included
make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

Labels
lang:javascript pattern:types
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TS] support boolean and number typed metavariables semgrep/semgrep
2 participants
@aryx @r2c-demo