Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metavariable-pattern not flagging with PHP code #5443

Closed
1 of 3 tasks
colleend opened this issue Jun 7, 2022 · 3 comments · Fixed by #5501
Closed
1 of 3 tasks

metavariable-pattern not flagging with PHP code #5443

colleend opened this issue Jun 7, 2022 · 3 comments · Fixed by #5501
Labels
bug Something isn't working lang:generic generic mode issues (spacegrep, aliengrep) lang:php

Comments

@colleend
Copy link
Contributor

colleend commented Jun 7, 2022

Describe the bug
Metavariable-pattern is flagging PHP code with 'generic' mode, but not with 'php' mode.

To Reproduce
For instance, this doesn't flag: https://semgrep.dev/s/WRD2

But this does: https://semgrep.dev/s/02Wj

Expected behavior
Would expect it to flag with php as the language.

Priority
How important is this to you?

  • P0: blocking me from making progress
  • P1: this will block me in the near future
  • P2: annoying but not blocking me
@colleend colleend added the bug Something isn't working label Jun 7, 2022
@minusworld minusworld transferred this issue from semgrep/semgrep-rules Jun 7, 2022
@r2c-demo
Copy link
Collaborator

r2c-demo commented Jun 7, 2022

This issue is synced in Linear at https://linear.app/r2c/issue/PA-1448/metavariable-pattern-not-flagging-with-php-code. Note: this link is for r2c use only and is not accessible publicly.

@aryx aryx added lang:php lang:generic generic mode issues (spacegrep, aliengrep) labels Jun 7, 2022
@aryx
Copy link
Collaborator

aryx commented Jun 7, 2022

@colleend
Copy link
Contributor Author

colleend commented Jun 7, 2022

Ah yes -- sorry, I totally forgot about this 😅 -- I'll update the issue on linear 👍 . Should I close this GH issue?

@aryx aryx closed this as completed Jun 13, 2022
aryx added a commit that referenced this issue Jun 13, 2022
This closes #5443

test plan:
test file included
make test
aryx added a commit that referenced this issue Jun 13, 2022
This closes #5443

test plan:
test file included
make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lang:generic generic mode issues (spacegrep, aliengrep) lang:php
Development

Successfully merging a pull request may close this issue.

3 participants