Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated support email in cli #8437

Closed
1 of 3 tasks
its-a-lisa opened this issue Aug 10, 2023 · 0 comments · Fixed by #8446
Closed
1 of 3 tasks

Outdated support email in cli #8437

its-a-lisa opened this issue Aug 10, 2023 · 0 comments · Fixed by #8446
Assignees
Labels
cli Semgrep CLI user:external requested by someone outside of r2c

Comments

@its-a-lisa
Copy link

its-a-lisa commented Aug 10, 2023

Describe the bug
Something I was doing ended up failing and I got the following message

Downloaded binary failed version check, try again or contact support@r2c.dev
This caused me to be confused because I only know about Semgrep and I'm not familiar with returntocorp. When I went to the semgrep website and navigated to the support page in the website, the email provided was listed as support@semgrep.com so I was further confused based on the mismatch

To Reproduce
Cause a Downloaded binary failed version check failure.

Expected behavior
I expected to be presented with support@semgrep.com instead of support@r2c.dev in the error message.

Screenshots
image

What is the priority of the bug to you?

  • P0: blocking your adoption of Semgrep or workflow
  • P1: important to fix or quite annoying
  • P2: regular bug that should get fixed

Environment
local build

Use case
It will enable me to trust the product and company more. Having the mismatch makes it feel a little phishy to a new user. I wouldn't feel comfortable sending my support tickets to an entity not clearly tied to the product. Now that I'm submitting this ticket, I see that this repo is affiliation to returntocorp, aka r2c; but that wasn't clear by any of the marketing websites of the product, which was my introduction to the tool that I was using.

@IagoAbal IagoAbal added user:external requested by someone outside of r2c cli Semgrep CLI labels Aug 11, 2023
IagoAbal added a commit that referenced this issue Aug 11, 2023
Closes #8437

test plan:
semgrep scan --help # see --pro for example
IagoAbal added a commit that referenced this issue Aug 11, 2023
Closes #8437

test plan:
semgrep scan --help # see --pro for example
@IagoAbal IagoAbal self-assigned this Aug 11, 2023
aryx pushed a commit that referenced this issue Aug 12, 2023
Closes #8437

test plan:
semgrep scan --help # see --pro for example

PR checklist:

- [x] Purpose of the code is [evident to future
readers](https://semgrep.dev/docs/contributing/contributing-code/#explaining-code)
- [x] Tests included or PR comment includes a reproducible test plan
- [x] Documentation is up-to-date
- [x] A changelog entry was [added to
changelog.d](https://semgrep.dev/docs/contributing/contributing-code/#adding-a-changelog-entry)
for any user-facing change
- [x] Change has no security implications (otherwise, ping security
team)

If you're unsure about any of this, please see:

- [Contribution
guidelines](https://semgrep.dev/docs/contributing/contributing-code)!
- [One of the more specific guides located
here](https://semgrep.dev/docs/contributing/contributing/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Semgrep CLI user:external requested by someone outside of r2c
Development

Successfully merging a pull request may close this issue.

2 participants