Fix location of same-file findings-divider (--------) #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em. However, for autofix, we were then printing the autofix after that line, visually grouping it with the wrong item. The easiest fix is to move the autofix print above finding_to_line, which is where the conclusing ----- gets printed. Alternatively, we could keep the logic for printing the divider one level up, in build_normal_output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple findings exist for a file, we print a ------ between them. However, for autofix, we were then printing the autofix after that line, visually grouping it with the wrong item.
The easiest fix is to move the autofix print above finding_to_line, which is where the concluding ----- gets printed. Alternatively, we could keep the logic for printing the divider one level up, in build_normal_output.
Before:
After:
PR checklist: