Fix adjust_for_docker #3732
Merged
Fix adjust_for_docker #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Does this close #2123 also? |
|
I don't think so. This change will only stop chdir when not in docker. #2123 looks like behavior in docker container |
|
Thanks for approval. I have to double check with legal before I sign the CLA. Stay tuned. |
|
Signed CLA |
|
🙏 @ChrisBr thanks for the contribution! @brendongo want to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to me that the
chdiris missing one level of indentation because it basically gets executed every single time. So even locally, if thesrcdirectory exists it wouldchdireven though we're not in docker.This caused us a couple of hours of debugging at Shopify.
I know there were several attempts to fix the whole docker chdir issue #3125 and #3134 but this seems unrelated and I just wanted to bring it up.
Also fine if you decide to not fix it as we can work around with setting the path in an env variable.
PR checklist: