fix: Match TyN pattern against TyExpr (N ...) source #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcqd
approved these changes
Jun 15, 2022
|
Oh, also I need to update the changelog |
See the changed test for the goal. In JS, constructors can be arbitrary expressions, so they are parsed into `TyExpr`. However, that leads to missed matches. The obvious solution is to desugar `TyExpr (N ...)` to `TyN` while constructing the AST. I first tried to do this by modifiying `AST_generic_helpers.expr_to_type` to do this desugaring, but I ran into the regression test added in #4682. It would be nice if there were a point where we could do this desugaring, rather than having to handle it specifically in matching. I'm not sure where it would make sense to do so, though. Test plan: Automated tests
|
📸 The pytest shapshots changed in your PR.
|
|
@nmote security team is fixing the registry state which caused your test failure. Please don't apply the snapshot changes & feel free to merge with pytest failing. |
|
@underyx thanks, I was just looking into that. Wasn't going to apply without figuring out what was going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changed test for the goal. In JS, constructors can be arbitrary
expressions, so they are parsed into
TyExpr. However, that leads tomissed matches.
The obvious solution is to desugar
TyExpr (N ...)toTyNwhileconstructing the AST. I first tried to do this by modifiying
AST_generic_helpers.expr_to_typeto do this desugaring, but I ran intothe regression test added in
#4682.
It would be nice if there were a point where we could do this
desugaring, rather than having to handle it specifically in matching.
I'm not sure where it would make sense to do so, though.
Test plan: Automated tests
PR checklist: