Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox for images #61

Open
axonasif opened this issue Jul 6, 2021 · 5 comments
Open

Lightbox for images #61

axonasif opened this issue Jul 6, 2021 · 5 comments
Assignees
Labels

Comments

@axonasif
Copy link

axonasif commented Jul 6, 2021

Hi again.
It would be nice if we could click on images, plus the ability to zoom into them over a simple lightbox.
Thanks.

See also

@geoffreymcgill
Copy link
Contributor

geoffreymcgill commented Jul 6, 2021

Thanks for the feature request.

I will keep this in mind and try to come up with some options. Might be best to implement as another Retype component that you explicitly configure as a lightbox image. Something like:

![!lightbox A caption here](../static/photo1.jpg)

@axonasif
Copy link
Author

axonasif commented Jul 6, 2021

Thanks for the feature request.

I will keep this in mind and try to come up with some options. Might be best to implement as another Retype component that you explicitly configure as a lightbox image. Something like:

![!lightbox A caption here](../static/photo1.jpg)

That seems like a better idea 🙌

@DannyBen
Copy link

DannyBen commented Jul 22, 2021

One thing to keep in mind in my opinion:

More often than not, these lightbox-style image popups end up creating a less polished experience. I am not saying it can't be implemented nicely, juts that I have seen more cases where it harms my experience instead of improving it.

I am saying it also since Retype right now is near-perfect in terms of how it renders, and I would be guarding its "spirit" like a hawk.

When I absolutely had to allow users to enlarge an image (animated screencast in my case), I just linked it to a hidden page with a central layout: See the screencast on this page.

Lastly, another point to consider:

  • Desktop people don't need to enlarge, since they have a large screen, and we are not presenting "photo galleries" here, but rather screenshots and the likes.
  • Mobile people don't need to enlarge, since images already take the full width of the screen.

@Euan-McVie
Copy link

Definitely agree that it should be separate component and so opt in as 95% of the time we don't need the behaviour.
Occassionally though we hae arch diagrams that are very large and so need zoom controls even on a larger monitor.
e.g.
image

@Canadastartes
Copy link
Contributor

We have a handful of large images and a separate lightbox component would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants