Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WireType.Fixed128 & leave as reserved #105

Closed
ReubenBond opened this issue Jan 21, 2021 · 1 comment
Closed

Remove WireType.Fixed128 & leave as reserved #105

ReubenBond opened this issue Jan 21, 2021 · 1 comment
Milestone
1.0

Comments

@ReubenBond
Copy link
Owner

This WireType is unnecessary and rarely used. I rather we keep it as reserved for the time being. This will mostly require rewriting the Guid codec to use a length prefix instead.
@ReubenBond ReubenBond added this to the 1.0 milestone Jan 21, 2021
@mcm2020
Copy link
Contributor

mcm2020 commented Jan 28, 2021

The Decimal Codec also uses Fixed128 -- should this be rewritten as well?

This was referenced Jan 29, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@ReubenBond @mcm2020