Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #147 - Allow to limit the number of articles listed per taxonomy entry #148

Merged
merged 6 commits into from
May 15, 2020
Merged

Fixes #147 - Allow to limit the number of articles listed per taxonomy entry #148

merged 6 commits into from
May 15, 2020

Conversation

palant
Copy link
Collaborator

@palant palant commented May 15, 2020

This adds a new config entry limitEntriesLimit. Default value is -1: do not limit the number of articles to be displayed per taxonomy term (current behavior). It can be set to 0, no articles will be listed for the taxonomy terms then. For positive numbers the list will be truncated and a "Read more >>" link added if necessary, pointing to the full listing of articles for this taxonomy term.

@palant
Copy link
Collaborator Author

palant commented May 15, 2020

Btw, I was very surprised to see browsers allow <h2> to be nested directly within <ul>. According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul, only <li>, <script> and <template> should be allowed - I'd assume that this is a compatibility hack. So it might be a good idea to move the term title heading out of the list in taxonomy.html.

@reuixiy
Copy link
Owner

reuixiy commented May 15, 2020

This feature is nice!

I was very surprised to see browsers allow <h2> to be nested directly within <ul>.

My mistake, we can solve this in another PR later.

@reuixiy reuixiy merged commit f3d9ad0 into reuixiy:master May 15, 2020
ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this pull request Nov 22, 2020
…reuixiy#148)

* Fixes reuixiy#147 - Allow to limit the number of articles listed per taxonomy entry

* Improved styling of the "Read more" link

* Move the position and respect the ruler of 42

* Add new param to zh-cn/config.toml

* Correct zh-cn translation of readMore

* Update resources folder

Co-authored-by: reuixiy <reuixiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants