Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger #60

Open
adamkleingit opened this issue Jul 7, 2019 · 2 comments
Open

Add logger #60

adamkleingit opened this issue Jul 7, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@adamkleingit
Copy link
Collaborator

Configurable in Provider, for example:
<ReusableProvider logger={NODE_ENV === 'development'}>

By default it's false

@adamkleingit adamkleingit created this issue from a note in V1 (To do) Jul 7, 2019
@adamkleingit adamkleingit changed the title Added logger Add logger Jul 7, 2019
@adamkleingit adamkleingit added enhancement New feature or request good first issue Good for newcomers labels Jul 13, 2019
@yarindeoh yarindeoh self-assigned this Jul 21, 2019
@yarindeoh yarindeoh moved this from To do to In progress in V1 Jul 23, 2019
@adamkleingit
Copy link
Collaborator Author

Suggestions:

What should be logged:

  • Every change to a unit's value
  • Which subscribers were triggered

Use colors/grouping if it makes it more aesthetic (see Redux-Logger for example):
https://github.com/LogRocket/redux-logger

@morsdyce @yarindeoh opinions?

@yarindeoh
Copy link
Collaborator

@adamkleingit @morsdyce Agreed, it can be a good start point for debugging options

@yarindeoh yarindeoh moved this from In progress to To do in V1 Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
V1
  
To do
Development

No branches or pull requests

2 participants