Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semver-ignore configuration in update-versions maven goal #190

Open
metlos opened this issue Jul 8, 2020 · 0 comments
Open

Use semver-ignore configuration in update-versions maven goal #190

metlos opened this issue Jul 8, 2020 · 0 comments
Projects

Comments

@metlos
Copy link
Member

metlos commented Jul 8, 2020

The update-versions maven goal uses hardcoded semantics to determine the required version update. All breaking changes require major version increase, non-breaking and potentially-breaking changes require a minor version increase and patch version is only ever increased in 0.x.y on non-breaking or potentially-breaking.

With the more advanced logic available in the semver-ignore extension, this is clearly insufficient.

Funnily enough the update-versions goal disallows the semver-ignore extension during analysis (for obvious reasons), but it should be clever enough to read its configuration. This will require some trickery during the revapi instantiation to read the full config first, extract what we need and only then proceed with disallowing extensions.

When at it, it would be nice to disallow extensions by their extension id, not by their class names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant