Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevBayes should maybe do site-compression based on the RbBitSet state? #121

Open
bredelings opened this issue Dec 17, 2020 · 0 comments
Open

RevBayes should maybe do site-compression based on the RbBitSet state? #121

bredelings opened this issue Dec 17, 2020 · 0 comments
Assignees
@bredelings
Labels
enhancement New feature or request

Comments

@bredelings
Copy link
Contributor

When revbayes is doing site compression, it characterizes site-patterns as a string.

This causes trouble if character_state->getStringValue() doesn't handle ambiguous characters.

It seems that maybe instead of representing site patterns as a string, they should be represented as a vector<RbBitSet>?

In order for this to work, we need to implement std::less on vector<RbBitSet>, so that we can use map< pattern_t,size_t>
@bredelings bredelings self-assigned this Feb 2, 2021
@bjoelle bjoelle added the enhancement New feature or request label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bredelings bredelings

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bredelings @bjoelle