Revel Code Styleguide

[brendensoares]

Seems clear that given so many contributors, we need to enforce a more consistent coding style.

One example is import grouping by Go runtime packages and 3rd party in alphabetical order (reference).

[notzippy]

Since we are splitting up the revel commands, samples and modules we should also add a gerrit server to the mix. So we can make changes that affect multiple repositories in one sweep. Also makes code review and approval easier..

[ghost]

go fmt has been a requirement for a long of time (BTW it automagically sorts imports in alphabetical order). Can we make go lint a one more requirement, so most style mistakes are fixed as well?

[brendensoares]

@notzippy Gerrit doesn't look like it adds anything that github already offers. Please explain how it would benefit us.

@AnonX that sounds like a good idea to experiment with.

[notzippy]

@brendensoares It would be a long discussion comparing gerrit patchsets and github PRs (I just put it out there as gerrit IMHO does a better job of developing an improvement). FYI http://gerrithub.io links directly to github, personally I have not used gerrithub (once again just spewing out random thoughts).

[brendensoares]

@notzippy nice that it doesn't require us to self host it. It's definitely something to look at in the future (after we make some decent progress on the current roadmap).

[pushrax]

@AnonX the bit about sorting imports was actually about leaving blank lines between groups of packages. Check out the link.

IMO just following all of https://code.google.com/p/go-wiki/wiki/CodeReviewComments would get us 90% of the way there.

[ghost]

the bit about sorting imports was actually about leaving blank lines between groups of packages. Check out the link.

@pushrax I know. This issue is likely partially inspired by the latest comments in discussion #606.

[ghost]

Interesting link: http://goreportcard.com

[brendensoares]

@AnonX sweet tool! Revel got a B. Room for improvement :)

[notzippy]

Added badge