Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation for 'find-transitive-eclipse-updates.sh' and it does not work on windows without additional software #848

Closed
hazendaz opened this issue Mar 17, 2024 · 1 comment
Labels

Comments

@hazendaz
Copy link
Member

Please document this process on readme so its known how to use. Further explain instructions to install software or rewrite it so its not using yet additional software to update libraries. My preference would be to use a proper bot (renovate) and configure it to group them (simple).

@hazendaz hazendaz added the bug label Mar 17, 2024
@ctubbsii
Copy link
Member

It was doing more than just keeping them up-to-date. What it was specifically doing was deleting them from the POM, and then automatically resolving the version ranges specified in the JDT core POM for all its transitive dependencies, and re-adding them to the POM. This way, it didn't just update them, but updated them to only within the range supported by upstream JDT core, and also removed any that would have been removed upstream. Renovate couldn't do that.

The only software it required was software that's available out of the box on *nix systems. It wasn't really intended to be used by everybody... just automation for me so I didn't have to manually run it when we bumped the JDT core library to the latest Eclipse. The description of it was in 1ac162a when it was added, and it takes no arguments. It just required running right after updating the JDT core dependency. Very simple.

In any case, it was a temporary workaround and we don't need it now because upstream doesn't use version ranges anymore, and it has already been deleted. So, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants