Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - persistent dashboard selection #119

Closed
RoryNesbitt opened this issue Aug 25, 2022 · 8 comments
Closed

Feature Request - persistent dashboard selection #119

RoryNesbitt opened this issue Aug 25, 2022 · 8 comments

Comments

@RoryNesbitt
Copy link

If I select a dashboard other than default this will be what I see each time I open fenrus again, until I close my browser.
It would be really great if this was persistent each time I opened my browser, so we can have different devices or different browser profiles using the same instance and account but with different selected dashboard

@revenz
Copy link
Owner

revenz commented Aug 25, 2022

it should be saving the selected dashboard to a cookie and then that is used when loading fenrus.
this is certainly working on my instance, as I use a work dashboard on my work computer and a default one on my personal computer.

@RoryNesbitt
Copy link
Author

that's interesting, mine only lasts as long as the browser session lasts. Maybe I've got a broken setting somewhere

@revenz
Copy link
Owner

revenz commented Aug 26, 2022

Look at the network requests, look to see if the cookie is being sent/saved. maybe you have a addon/service that disables cookies?

@RoryNesbitt
Copy link
Author

RoryNesbitt commented Aug 26, 2022

There is indeed cookies being requested, I assume the one named dashbaord is for Fenrus? it seems to change when I change the selected dashboard
There is also one for jwt, I'm not sure what it's for, and two for organizr even though I'm not loading that These seem to be for links connecting to app apis

@RoryNesbitt
Copy link
Author

What seems to be happening is the cookie is only requested if I select a dashboard that session. if I haven't selected one (i.e. I first open the browser) the dashboard cookie isn't requested and therefore I'm getting default

@revenz
Copy link
Owner

revenz commented Aug 26, 2022

The entire reason to use a cookie is so it's persistent and sent with every request.
Try a different browser. curious if it's a browser issue or a machine. Also, do you have a different machine you could try?

@RoryNesbitt
Copy link
Author

tried with firefox and vivaldi on two different machines (both are running endeavour with i3, but I made a point to ask the browser to close nicely instead of using the close window keybinding). both machines with both browsers have this exact issue

on the other side the traffic is going via cloudflare with caching, to traefik, to fenrus (a setup that has never caused me issues before) and I never get signed out so cookies in general do work, just the dashboard one

@revenz
Copy link
Owner

revenz commented Dec 2, 2022

closing as unable to reproduce this

@revenz revenz closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants