Smart app Speedtest Tracker #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is where you would want to use a gauge IMO. something I told you I'm looking into :P Then get the user to set the maximum of the gauge (me I would put 1000Mps, probably a sensible default), and just work on that. |
|
I think the graph is useful for tracking historically and things. Personally I'd prefer it more than a gauge for this use case But I can 100% see people preferring the gauge for the average/latest stats section for dl speed tracking etc |
|
I'll hold off changes :) |
|
Added configurable Max download/upload (Mb/s) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying out graphs and stuff
Stating max Y in title since no other way to tell whats happening.... unless have the user state max speed or show the graph values?