Support Firebase version 7 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR @getogrand, sorry for responding late was very busy for couple of weeks, will look and test PR by sunday this week. Meanwhile any new thoughts or improvement is very much appreciated. |
|
This PR redundant as #14, if I am missing any thing please open this again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use Firebase version 7 SDK due to the
s.dependency 'FirebaseFirestoreSwift', which is the last non-beta version is '0.4.0'.The 'FirebaseFirestoreSwift 0.4.0' depends on 'FirebaseFirestore ~> 1.6, FirebaseFirestore >= 1.6.1' and it blocks to update Firestore and Firebase SDK version.
This PR sets FirebaseFirestoreSwift to '~> 7.3.0-beta'.
It unlocks the updating of FirebaseSDK version, but unfortunately it has beta versioning so it won't be resolved any other version (e.g. 7.3.1-beta, 7.4.0-beta, etc..).
So we should change the 'CombineFirebaseFirestore.podspec' on every future 'FirebaseFirestoreSwift' releases.