Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - Colors: Implement full set of colors available from HTML #103

Closed
bryphe opened this issue Dec 7, 2018 · 3 comments
Closed

API - Colors: Implement full set of colors available from HTML #103

bryphe opened this issue Dec 7, 2018 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bryphe
Copy link
Member

bryphe commented Dec 7, 2018

We have a very small subset of Colors defined in our Colors module - like Colors.red, Colors.blue, etc.

It'd be great to have parity with the default set in HTML - I think this is a comprehensive list here:
https://www.w3schools.com/colors/colors_names.asp

Might be easier with #102 tackled - but it would be awesome to have this full set of Colors in revery, too!

Good place to start looking:
https://github.com/bryphe/revery/blob/master/src/Core/Colors.re

@bryphe bryphe added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 7, 2018
@bgoscinski
Copy link
Contributor

I'm on it :)

@bryphe
Copy link
Member Author

bryphe commented Dec 7, 2018

Sweet, thank you @bgoscinski 😄 Let me know if you need any help getting started!

@bryphe
Copy link
Member Author

bryphe commented Dec 7, 2018

Fixed with #106 ! Thank you @bgoscinski 💯

@bryphe bryphe closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants