-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text elements do not render correct background colors #57
Comments
Nice catch @Akin909. Definitely a bug with how we render text. The shader where we color / render the text is here: The 'texture' we use to read the font has only a single channel ( Some useful references I found for WebGL / Shaders:
|
@Akin909 - hope you don't mind - I took a go at this w/ #60. |
This should be fixed now, @Akin909 ! Let me know if it's not for you 👍 |
Setting a background for text elements does not set the color in the actual character's cell to match the overall background color leading to a patchy appearance, not entirely sure how to go about looking into this @bryphe, as the meat of how
revery
works aka shaders etc. is very new to me but could have a look if you point in me the right directionThe text was updated successfully, but these errors were encountered: