Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The suggedtion for Rails/RedundantActiveRecordAllMethod is incorrect #96

Open
massongit opened this issue Feb 18, 2024 · 0 comments
Open

Comments

@massongit
Copy link
Contributor

When running reviewdog/action-rubocop action, the suggestion for Rails/RedundantActiveRecordAllMethod that appears in the pull request review is incorrect.


Expected behavior

📝 [rubocop] <Rails/RedundantActiveRecordAllMethod> reported by reviewdog 🐶
Redundant all detected.

    User.find_by(1)

Actual behavior

massongit#2 (comment)

📝 [rubocop] <Rails/RedundantActiveRecordAllMethod> reported by reviewdog 🐶
Redundant all detected.

   User..find_by(1)

Steps to reproduce the problem

Example: massongit#2

I run reviewdog/action-rubocop action with the following conditions:

  • require: rubocop-rails
  • review dog reporter: github-pr-review

RuboCop version

https://github.com/massongit/action-rubocop/actions/runs/7947724505/job/21696894186?pr=2

  Successfully installed rubocop-ast-1.30.0
  Successfully installed rexml-3.2.6
  Successfully installed regexp_parser-2.9.0
  Successfully installed rainbow-3.1.1
  Successfully installed parallel-1.24.0
  Successfully installed language_server-protocol-3.17.0.3
  Successfully installed rubocop-1.60.2
  11 gems installed
  Successfully installed rack-3.0.9
  Successfully installed ruby2_keywords-0.0.5
  Successfully installed drb-2.2.0
  Successfully installed base64-0.2.0
  Successfully installed connection_pool-2.4.1
  Successfully installed concurrent-ruby-1.2.3
  Successfully installed tzinfo-2.0.6
  Successfully installed i18n-1.14.1
  Successfully installed activesupport-7.1.3
  Successfully installed rubocop-rails-2.23.1
  10 gems installed
  Successfully installed rubocop-performance-1.20.2
  1 gem installed
  Successfully installed rubocop-factory_bot-2.25.1
  Successfully installed rubocop-capybara-2.20.0
  Successfully installed rubocop-rspec-2.26.1
  3 gems installed
  Successfully installed rubocop-i18n-3.0.0
  1 gem installed
  Successfully installed rubocop-rake-0.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant