Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-reporter=github-pr-check doesn't work for private repo? #140

Closed
haya14busa opened this issue Jun 5, 2018 · 4 comments
Closed

-reporter=github-pr-check doesn't work for private repo? #140

haya14busa opened this issue Jun 5, 2018 · 4 comments

Comments

@haya14busa
Copy link
Member

failed to run checker: fail to parse diff: GET https://api.github.com/repos/xxx/xxx/pulls/xxx: 403 Resource not accessible by integration []

reviewdog doesn't have necessary permission? It has read permission of pull requests, so i wonder why...

@haya14busa
Copy link
Member Author

haya14busa commented Jun 5, 2018

oh, i got it.

To get diff, go-github uses application/vnd.github.v3.diff but GitHub app is in preview mode so need to specify "application/vnd.github.machine-man-preview+json"

If i changed the header to "application/vnd.github.machine-man-preview+diff", it works...!

@haya14busa
Copy link
Member Author

reported: google/go-github#924

@haya14busa
Copy link
Member Author

It turns out that the app needs Read-only access to Repository contents to get diff.
Updated the request permission of reviewdog app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant